CRM-21001 E-notice in com_civicrm/civicrm/CRM/Core/BAO/SchemaHandler.php #11307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a straight forwards e-notice fix - ok to merge |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
mlutfy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Undefined index error in SchemaHandler.php
Before
The current status. Please provide screenshots or gifs (LICEcap, [SilentCast](https://github.com/
colinkeenan/silentcast)) where appropriate.
After
The error no longer appears.
Technical Details
Define two array variables before they are used.
Wrap the foreach loop in line 750 with an if statement checking for the existence of the index.
Comments
This probably addresses CRM-20749, CRM-21101 and CRM-20766