CRM-21486: Support multiple test mail #11332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monishdeb tested and confirmed it's working as expected. With this change, you can now enter multiple email addresses -- comma separated. The email test button is greyed out unless each comma-separated value is validated as an email address. |
|
Code looks good. Merging based on @lcdservices review. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21486: Support multiple test mail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the old version, you could add multiple email addresses in the test email window as long as they were separated by commas. This issue is about retaining this old behavior.
Before
After
Technical Details
Theres still work going on to support multiple email field in angularJs, see. So I have introduced directive
crm-multiple-emailto support comma separated multiple emails.