CRM-21470 Ensure we don't have an empty locale #11333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that it would not make sense to pursue the innids of that IF when $language is empty - so the change is a sensible e-notice fix |
|
Jenkins re test this please |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21470 Ensure we don't have an empty locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to #11312 which has been committed.
In admin pages, Polylang as an option to display "Show all languages" instead of forcing one language. When we do so, it gives some PHP notice errors because CiviCRM is not able to find corresponding locale.
Before
Notice: Undefined index: in /var/aegir/platforms/wordpress/wp-content/plugins/civicrm/civicrm/CRM/Core/I18n/PseudoConstant.php on line 44
After
No notices.
Technical Details
Use
!emptyinstead ofisset