Unit test for CRM-21436 #11334
Merged
Unit test for CRM-21436 #11334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrapurohit
changed the title
|
@jitendrapurohit doing some more review on this I believe there is an id set in |
jitendrapurohit
force-pushed
the
CRM-21436-unittest
branch
from
21f56cc
to
1f3c6d3
Compare
|
Yes @seamuslee001 I've updated the PR by setting page id to $_REQUEST and |
jitendrapurohit
force-pushed
the
CRM-21436-unittest
branch
from
1f3c6d3
to
3ae4b3c
Compare
jitendrapurohit
force-pushed
the
CRM-21436-unittest
branch
from
3ae4b3c
to
43b4ba4
Compare
|
Looks good (should we remove the WIP now @jitendrapurohit ?) also ping @eileenmcnaughton |
eileenmcnaughton
changed the title
|
A test that passes is a mergeable test IMHO. Thanks for the follow through @jitendrapurohit |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
Unit test for CRM-21436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit test for #11317