CRM-21501 bounce report date filter type fix #11354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a really simple change I am happy to merge based on reading the code |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21501 bounce report date filter type fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the Mailing Bounce report, if you filter by the bounce date, the query construction only includes the date – no time value. As a result, the end date is not inclusive. To reproduce, filter on the relative date "Today."
Before
Filter by bounce date = Today. No records are returned. Analysis of the Developer tab confirms the date range is constructed without time values.
After
Time values included in the query where clause. Results are returned.
Technical Details
The filter declaration for this field needs to include both date and time.