Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-16421 - distmaker - Set version in WP zip files #11397

Merged
merged 2 commits into from
Dec 12, 2017

Conversation

totten
Copy link
Member

@totten totten commented Dec 12, 2017

Overview

When preparing zip files for WordPress, the Version: header should specify the actual version.

Before

The file civicrm.php always has Version: 4.7.

After

While building the zip file, civicrm.php is filtered to specify Version: 4.7.29 (or Version: 4.7.30 or similar).

Technical Details

This uses the same technique as the Drupal build (wherein *.info files are tweaked to match the actual version).

Due to the minor differences between GNU and BSD tool chains, the Drupal build script was sketchy. I rewrote that bit as a helper function (dm_preg_edit).

To test this, I ran the distmaker.sh locally for both the WordPress and D7 builds -- then inspected the resulting files to ensure that versions were correctly updated.

There isn't much to r-run on this patch -- just calling distmaker.sh. Alas, many folks aren't comfortable with that script. But there are automated builds on http://download.civicrm.org/latest . In lieu of r-run QA, perhaps we could merge and then have someone look at the new automated build? (We can quickly revert if the automated build fails.)



@totten
Copy link
Member Author

totten commented Dec 12, 2017

CC @kcristiano.

@kcristiano
Copy link
Member

@totten I agree merging and seeing how tar bars are built would be a good step forward.

I also ran distmaker and the build look good to me. I also tested manual installs of WP and D7, both worked fine with this patch

@colemanw colemanw merged commit 25ae8a6 into civicrm:master Dec 12, 2017
@colemanw
Copy link
Member

I've merged based on @kcristiano's review but it looks like the wrong issue was linked :(

@kcristiano
Copy link
Member

@colemanw I think this is the correct issue CRM-16421 is work to get in the WP directory, setting the version number to be readable in the plugin file is one of the necessary steps.

@totten totten deleted the master-wpver branch December 12, 2017 19:11
@totten totten changed the title CRM-16241 - distmaker - Set version in WP zip files CRM-16421 - distmaker - Set version in WP zip files Dec 12, 2017
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-16241 - distmaker - Set version in WP zip files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants