CRM-21563: Cannot search child tags on 'Manage Tag' page #11414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure that your CiviCRM instance has child tags then visit the 'Manage Tags' page and try to search the child tag name. You won't find the result.
Before
After
Technical Details
This PR introduces the fix along with some additional changes like replacing the hardcoded sql string with
CRM_Utils_SQL::execute()
and extended unit test to assert result on basis of subtring of tag name.Comments
This only happens on initial page load where child tags were hidden. If you click on parent tag to expose its child tags then the filter works.