Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21563: Cannot search child tags on 'Manage Tag' page #11414

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Dec 15, 2017

Overview

Ensure that your CiviCRM instance has child tags then visit the 'Manage Tags' page and try to search the child tag name. You won't find the result.

Before

test-multiple-before

After

test-multiple-after

Technical Details

This PR introduces the fix along with some additional changes like replacing the hardcoded sql string with CRM_Utils_SQL::execute() and extended unit test to assert result on basis of subtring of tag name.

Comments

This only happens on initial page load where child tags were hidden. If you click on parent tag to expose its child tags then the filter works.


@monishdeb
Copy link
Member Author

ping @colemanw @lcdservices

@lcdservices
Copy link
Contributor

@monishdeb this looks great. It now drills down into the tree to look for child nodes and then displays them in their branch structure.

@colemanw
Copy link
Member

colemanw commented Dec 15, 2017

  • (r-test) pass - adds unit test coverage
  • (r-code) pass - improves code quality
  • (r-doc) pass - no doc changes needed
  • (r-maint) pass - improves code quality & adds tests
  • (r-run) pass - tested by @lcdservices
  • (r-user) pass - makes the UI more consistent
  • (r-tech) pass - no impact

@colemanw colemanw merged commit 7906701 into civicrm:master Dec 15, 2017
@colemanw colemanw added this to the 4.7.30 milestone Dec 15, 2017
@monishdeb monishdeb deleted the CRM-21563 branch December 29, 2017 19:35
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-21563: Cannot search child tags on 'Manage Tag' page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants