CRM-21538: Field not found when sorting report by Case Type as a section header

[octo-happiness]

Overview

Attempting to create a Case Detail report sorted by the field Case Type with the option "Section Header" checked does not work.

Before

Creating a case detail report with this sorting configuration:

causes application to crash. The error is:

Unknown column 'case_civireport.case_type_name' in 'field list'

After

With this small change report generates as expected.

Comments

It appears that this field (added in CRM-20368 PR) requires special handling.

---

• CRM-21538: CiviReport: Field not found when sorting by Case Type as a section header
• CRM-20368: report templates: don't hard-code order bys

[civicrm-builder]

Can one of the admins verify this patch?

[colemanw]

@civicrm-builder add to whitelist

[colemanw]

@octo-happiness congrats on your first PR to CiviCRM 🥇
You've done a great job finding and documenting the bug, and providing what looks like a good solution.
As you can see our bot is very picky about syntax to keep our code clean, so the line you added needs to be indented by 2 fewer spaces (we use 2 spaces for indentation not 4). Typically when fixing minor things like that I'll do git commit --amend and git push --force to overwrite the previous commit and erase the mistake.

[octo-happiness]

Sorry for the spaces, I've missed the difference. Fixed now.

[colemanw]

I'm not able to reproduce the bug on my local setup. What version of CiviCRM are you using? What columns do you have enabled in the report? What extensions are you using?

[octo-happiness]

I've tested it on CiviCRM 4.7.27, with no extensions enabled.

Report type: Case Detail
Selected columns:

• Subject
• Client Name

Sorting:

• Case Type, ascending, with option "Section Header" checked

I can also replicate it on demo.circle-interactive.co.uk, I've made a screencap:

[colemanw]

Ah, that screencap helps, thank you. It was the "Section Header/Group By" checkbox I was missing. Now I can reproduce it and verify that your patch solves the problem.

• (r-jira) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass
• (r-user) Pass
• (r-tech) Pass

[colemanw]

@octo-happiness thanks again for a clean well documented PR. May you have a long and happy career contributing to CiviCRM 🎉