CRM-17647 fix for currency on batch entry #11549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@civicrm-builder retest this please |
|
test fail unrelated -see #11552 |
|
test this please |
|
I don't entirely understand how this code works but the test coverage looks adequate. |
|
yep it's the tests that I'm finding these with. The principle is that the formatting needs to be done close to the point of entry & not in the BAO (where it mishandles it if it has already been done & now more often than not) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#11539 identified that batch entry was also failing for thousand separator
Before
use of thousand separator resolved in missaved amounts
After
Amounts saved correctly, tests
Technical Details
Comments
See #11539