Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-21721, fixed notice error for Division by zero #11601

Merged
merged 1 commit into from
Feb 2, 2018
Merged

CRM-21721, fixed notice error for Division by zero #11601

merged 1 commit into from
Feb 2, 2018

Conversation

pradpnayak
Copy link
Contributor

@pradpnayak
CRM-21721, fixed notice error for Division by zero
ea8f914 
----------------------------------------
* CRM-21721: Notice : Division by zero
  https://issues.civicrm.org/jira/browse/CRM-21721
@mattwire
Copy link
Contributor

Hey @pradpnayak this looks like a duplicate of #11292

@pradpnayak
Copy link
Contributor Author

Ohhh.. I will close this against #11292

@pradpnayak pradpnayak closed this Jan 29, 2018
@pradpnayak pradpnayak reopened this Jan 30, 2018
@pradpnayak
Copy link
Contributor Author

@mattwire reopening this as per our discussion on #11292

@eileenmcnaughton
Copy link
Contributor

While I have a strong preference for unit tests on ALL changes that touch contributions I think I could let this slip through due to the triviality & the fact it's a non-core fix (interacts with a hook). This makes sense to me & from the discussion I feel it has been agreed - @mattwire if you confirm I will merge this.

Ok course - I really would prefer a unit test if either of you feel Ok to do one...

This was referenced Feb 2, 2018
Closed
Merged
@mattwire
Copy link
Contributor

mattwire commented Feb 2, 2018 •
edited
Loading

@eileenmcnaughton Ok I added a unit test in #11623

@mattwire
Copy link
Contributor

mattwire commented Feb 2, 2018

@eileenmcnaughton Confirm this is good to merge, and unit test should then pass in #11623

@eileenmcnaughton
Copy link
Contributor

Thanks @mattwire - merging based on your review & this being an agreed code change based on you both having worked on the bug

@eileenmcnaughton eileenmcnaughton merged commit 5fc836b into civicrm:master Feb 2, 2018
@mlutfy mlutfy added this to the 4.7.31 milestone Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
4.7.31
Development

Successfully merging this pull request may close these issues.
5 participants
@pradpnayak @mattwire @eileenmcnaughton @mlutfy @civicrm-builder