Fix page layout for wordpress (dev/core/issues/21) #11827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colemanw one for you |
|
jenkins, test this please |
eileenmcnaughton
changed the title
|
FYI @mukeshcompucorp I'm merging this due to the regression. |
|
@colemanw sorry, I didn't got time to work on this. Yes, it seems to merge it safely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reverse formatting change that caused a regression in 4.7.31 for the display of contribution pages in wordpress
Before
After
Technical Details
Change reverses a css change in 036aa39#diff-544215f9c296467a07bab9c92c448be0R71
Comments
I think this will cause something in PR #11396 to regress but that can be fixed in a more leisurely fashion later - this appears as a serious regression that needs to be fixed in the next code drop