(dev/core#316) Fix crash on Memcache systems when session key involves whitespace #12653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this method is performance related and called frequently, no need to recalculate results from preg_replace_callback() with the same inputs.
This is replaces 95b6567. The intent is to have a delimiter every ten chars so that it's easy to read/confirm the length of the string. The delimiter was space, but this became a longer encoded char (`-20`) and threw off the numbers. Switching to dash just gives a different encoded char. To get the counts right, it needs ot be a pass-through char... like underscore.
|
(Standard links)
|
totten
changed the title
|
This has been approved for the rc so OK to merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As reported in dev/core#316, there's an issue with Memcache compatibility - keys generated by Cache::cleanKey() permit whitespace, which Memcache does not allow.
This patch addresses the bug and also micro-optimizes some cache logic. It is a backport of #12640.
Before
cleanKey()is called twice in a row.After
cleanKey()is called once.