Fix quirks in upgrader UI #12675
Merged
Fix quirks in upgrader UI #12675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion @bgm pointed out that the permission name should be translated as well. This left me wondering... why do we bother with parameterizing the string with a `%1` if it's all going to be translated anyway? There is a plausible reason. It's not super-critical, but it's plausible -- the permission name is used in more contexts (like the permission mgmt screen in D7/WP *as well as* the upgrade screen). This arrangement ensures that the name appears the same in *all those contexts*, even in various edge-cases of the translation lifecycle (e.g. where the permission-names have been translated but the upgrade-messages have not). Again... it's not a big deal, but it is a slightly better default.
Also: Fix a layout issue caused by a typo in the `<li>` tag.
|
(Standard links)
|
|
I gave this a spin on 5.4 & it looked good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport for 5.4.x of two PRs which address quirks in the upgrade experience:
save Report Criteria