Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure hard-coded date ranges are preserved in smart groups #12909

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

See https://lab.civicrm.org/dev/core/issues/396

Overview

Due to a regression introduced by #11486, smart groups based on manually entered date ranges fail to properly filter by the date ranges when executed.

Before

If you create a smart group based on a search using one of several specially identified date fields (including event participant registration date) and you manually specify a date range instead of selecting a pre-chosen range, then your smart group will be properly saved, but the date range will be ignored when the saved search is executed.

After

Smart groups based on manually selected date ranges properly select the right contacts based on the date ranges entered.

Technical Details

Prior to the fix, CiviCRM issued an undefined index error.

Comments

This is a reviewer's commit. I reviewed @jmcclelland patch & decided

  1. it works
  2. the issue is on save rather than on load so groups created while this is broken will be incorrect. I think we should consider a 5.6.1 drop @seamuslee001 @totten - getting this into the rc as a first step

@civibot
Copy link

civibot bot commented Oct 9, 2018

(Standard links)

@civibot civibot bot added the 5.7 label Oct 9, 2018
@eileenmcnaughton eileenmcnaughton changed the title ensure date ranges are preserved in smart groups Ensure hard-coded date ranges are preserved in smart groups Oct 9, 2018
@eileenmcnaughton
Copy link
Contributor Author

Original pr #12831

@eileenmcnaughton
Copy link
Contributor Author

Mergins as this is a reviewer's commit

@eileenmcnaughton eileenmcnaughton deleted the 57reg branch October 9, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants