Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact summary report with location type selected :Fixed fatal error for function not found #12967

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 18, 2018

Overview

Contact summary report with location type selected :Fixed fatal error for function not found

Before

screen shot 2018-10-18 at 10 22 09

After

screen shot 2018-10-18 at 10 22 27

Technical Details

Function $this->getLocationTypeOptions() not present in CRM_Core_Form(), so replaced with CRM_Core_PseudoConstant::getLabel() to retrieve labels for Location type.

replaces #12953 (against the rc)

@civibot
Copy link

civibot bot commented Oct 18, 2018

(Standard links)

@civibot civibot bot added the master label Oct 18, 2018
@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.7 October 18, 2018 21:34
@civibot civibot bot added 5.7 and removed master labels Oct 18, 2018
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

I don't really understand the test results :-(

@pradpnayak
Copy link
Contributor

Thanks @eileenmcnaughton

@totten totten merged commit 03d7e77 into civicrm:5.7 Oct 19, 2018
@eileenmcnaughton eileenmcnaughton deleted the report57 branch October 20, 2018 20:51
@eileenmcnaughton
Copy link
Contributor Author

@pradpnayak thanks for the patch!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants