[NFC] Extract function to get component permissions #12994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -2772,7 +2730,7 @@ public static function checkPermission($activityId, $action) { | |||
| $targetID = CRM_Utils_Array::key('Activity Targets', $activityContacts); | |||
|
|
|||
| // Check for source contact. | |||
| if (!$componentId || $allow) { | |||
There was a problem hiding this comment.
@eileenmcnaughton this seems to be a bit odd given that what if there is no component id?
There was a problem hiding this comment.
@seamuslee001 yeah I remove componentId there because I return TRUE when componentId if NULL from the hasPermission function. $allow is reset 2 lines after that point so the change doesn't carry on past there
|
I am satisfied that nothing is changing here and it is in deed NFC |
|
Merging |
|
thanks @seamuslee001 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Function extraction as part of code simplification
Before
Code harder to read
After
Code easier to read
Technical Details
Just an extraction
Comments
I will follow this with fixes described in https://lab.civicrm.org/dev/core/issues/454 with the end goal of making getcount work with permissions