Commits on Oct 24, 2018

1. Fix hasPermissionForActivityType to use components function. …

   This is a refactor step - not the final destination. I want to move from loading
   all activities & then checking if each one can be accessed to determining a list
   of activity types and then adding that filter to the sql query. 2 reasons
   - performance
   - because getcount actually hard fails when permissions are applied currently :-(
   
   In this step I note the function activityComponents looks like it expected
   the concept of showActivitiesInCore by components to take off but in
   practice it is hard coded to 0 for CiviCase & CiviCase only. Oddly there is
   acually handling for CiviCase in this function in a place unreachable
   without the changes in this patch. In addition the few places that call this
   function also do weird CiviCase handling. I've opted for relatively low
   intervention since I think most places that call this function
   are likely to change themselves in the short-medium term.
   
   note this implements https://lab.civicrm.org/dev/core/issues/454 which slightly downgrades the relevant permission

   

   eileenmcnaughton committed Oct 24, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for c4937fe
   • Browse repository at this point

   Copy the full SHA

   c4937fe View commit details

   Browse the repository at this point in the history