Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-core#564: Differentiate case relationships in Contact Summary page #13189

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

monishdeb
Copy link
Member

Overview

The relationships tab doesn't do much to communicate that a given relationship is tied to a specific case. if you click "more" you can click to manage the case, but from the listing, there is no visual queue to connect it to a case, which makes the relationships look like duplicates.

Before

screen shot 2018-11-30 at 5 18 57 pm

After

after

As per this improvement:

  1. Adds a case icon against case-relationships.
  2. On hover, it opens a modal to show the case relationships info
  3. It has a 'Manage Case' link clicking which opens the Case management page in a medium dialog box

Comments

ping @colemanw @lcdservices

@civibot
Copy link

civibot bot commented Nov 30, 2018

(Standard links)

@civibot civibot bot added the master label Nov 30, 2018
@lcdservices
Copy link
Contributor

we've tested this PR and are already using in production.

@yashodha
Copy link
Contributor

@lcdservices @monishdeb
I tested it with civicase extension. The Manage Case link when clicked doesn't show anything in the popup
civicase
.

@lcdservices
Copy link
Contributor

I had tested with core CiviCase, so maybe the issue is specific to the case extension.

@mattwire
Copy link
Contributor

I like the extra icon and the case details on hover. But I'm not sure about the UI experience of having menu items on that same icon. Can the "manage case" link be added with the other links on the right instead?

@yashodha
Copy link
Contributor

@lcdservices yes this is specific to civicase extension

@monishdeb monishdeb force-pushed the core-564 branch 3 times, most recently from 91fe6b6 to 3caeb8e Compare December 31, 2018 02:35
@monishdeb
Copy link
Member Author

@lcdservices @mattwire @yashodha thanks for your feedback. I agree that its not necessary to show 'Manage Case' link in the action board, as we already have that as an action link in the right of a case relationship. This is how it looks now:
after

@lcdservices
Copy link
Contributor

@monishdeb tested and confirmed with CiviCase core. Looks good.

@yashodha
Copy link
Contributor

yashodha commented Jan 1, 2019

@monishdeb looks good to be merged. Can you squash your commits into one so that it is ready to be merged?

@monishdeb
Copy link
Member Author

Thanks @yashodha @lcdservices for your feedback. I have squashed the commits, can you please merge this PR now? Thanks

@seamuslee001
Copy link
Contributor

adding merge on pass based on review

@yashodha
Copy link
Contributor

yashodha commented Jan 2, 2019

@monishdeb sure, will merge soon after the tests pass

@seamuslee001
Copy link
Contributor

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@yashodha
Copy link
Contributor

yashodha commented Jan 2, 2019

test this please

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

Merging as per the tag

@seamuslee001 seamuslee001 merged commit 416569e into civicrm:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants