-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-core#564: Differentiate case relationships in Contact Summary page #13189
Conversation
(Standard links)
|
we've tested this PR and are already using in production. |
@lcdservices @monishdeb |
I had tested with core CiviCase, so maybe the issue is specific to the case extension. |
I like the extra icon and the case details on hover. But I'm not sure about the UI experience of having menu items on that same icon. Can the "manage case" link be added with the other links on the right instead? |
@lcdservices yes this is specific to civicase extension |
91fe6b6
to
3caeb8e
Compare
@lcdservices @mattwire @yashodha thanks for your feedback. I agree that its not necessary to show 'Manage Case' link in the action board, as we already have that as an action link in the right of a case relationship. This is how it looks now: |
@monishdeb tested and confirmed with CiviCase core. Looks good. |
@monishdeb looks good to be merged. Can you squash your commits into one so that it is ready to be merged? |
Thanks @yashodha @lcdservices for your feedback. I have squashed the commits, can you please merge this PR now? Thanks |
adding merge on pass based on review |
@monishdeb sure, will merge soon after the tests pass |
Jenkins re test this please |
1 similar comment
Jenkins re test this please |
test this please |
Jenkins re test this please |
Merging as per the tag |
Overview
The relationships tab doesn't do much to communicate that a given relationship is tied to a specific case. if you click "more" you can click to manage the case, but from the listing, there is no visual queue to connect it to a case, which makes the relationships look like duplicates.
Before
After
As per this improvement:
Comments
ping @colemanw @lcdservices