[REF] Export cleanup - filter at point of query on postal exports

[eileenmcnaughton]

Overview

Follow on from https://github.com/civicrm/civicrm-core/pull/13213/files
This culls out the non-postal rows at the query rather than deleting them at the end

Before

Query fetches rows that can't be emailed and THEN they are culled

After

Where filters added to query

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

See mattwire@4b8a3a2 for some tweaks to fix issues in #13213 and get merge household working

[mattwire]

@eileenmcnaughton I think this should be OR not AND!

[eileenmcnaughton]

I think you are right - if street address is not empty or supplemental address is not empty then we have an address we can email - updated

[mattwire]

@eileenmcnaughton This is tested and working now on a live site. Ok to merge.

I did have to make one change to set the table type to MYISAM instead of INNODB here https://github.com/eileenmcnaughton/civicrm-core/blob/30eab4c17d15d688acc039a5974a695386271a9e/CRM/Export/BAO/Export.php#L713 as I get row size to large otherwise. But that's a long-standing issue before/after this PR :-) It does, however, allow me to test and verify that all three contact export modes with/without postal selected now work correctly! Well done!