-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/translation#13 Enable users to choose their own language for accessing CiviCRM #13240
Conversation
(Standard links)
|
Jenkins re test this please |
Test Failure looks related @aydun |
@seamuslee001 In the test environment, are the l10n files installed? So does |
Jenkins re test this please |
hmm test failure here https://test.civicrm.org/job/CiviCRM-Core-PR/23519/testReport/junit/(root)/CRM_Core_I18n_LocaleTest/testUiLanguages/ still looks to be an issue @aydun maybe FR_CA isn't in the default one |
ping @mlutfy You might be into this one |
Yes - this is the thing we discussed at the Governance Summit |
@seamuslee001 Thanks for tracking down the issue in #13246 The tests here are passing cleanly now. |
Hi @aydun, this works great! I have only a small superficial request: can you change the string "UI Languages" to "Available Languages"? When we are in multi-lingual mode, the interface looks like this: I think the wording should be imitated. "UI" is a geeky term, and "Available languages" does not imply multi-lingual data anyway. (The "Languages available to users of this installation" doesn't mean anything useful, so I would ignore that string.) Testing
Documentation
|
Thanks @mlutfy - I've changed "UI Languages" to "Available Languages" |
Great! Seems OK to merge. |
Overview
Users on multilingual sites are able to select their language of choice from the available languages. Monolingual sites have only been able to set the language for all users.
This change enables users of monolingual sites to select their own language without affecting other users.
The background for this is https://lab.civicrm.org/dev/translation/issues/13 although this implementation has evolved from that suggested in the 'Approach' section. This replaces PR #12405
Before
In monolingual mode, /admin/setting/localization
After
In monolingual mode, /admin/setting/localization
Results in Language Switcher block being shown (same as in multilingual mode)
Technical Details
This introduces a new localization setting 'uiLanguages'. The existing logic for determining the appropriate language in multilingual mode is extended to monolingual (looking at request url, session, uf_match etc). In line with that, the language switcher block is not shown if the setting 'Inherit CMS Language' is set. The UI Languages setting on the settings page is not shown in multilingual mode nor when 'Inherit CMS Language' is selected.
There are no (intentional!) changes to multilingual mode
Comments
A documentation PR will be provided.