dev/core#592 Add default for in Exception class.

[eileenmcnaughton]

Overview

Fixes non-fatal error

ArgumentCountError: Too few arguments to function CiviCRM_API3_Exception::__construct(), 1 passed in [drupal root]/sites/all/modules/civicrm/Civi/API/Api3SelectQuery.php on line 130 and at least 2 expected in CiviCRM_API3_Exception->__construct()

Before

Above error occurs... when an error occurs

After

Only the error occurs....

Technical Details

Throw line is

            throw new \CiviCRM_API3_Exception("'$key' specified in OR group but not added to params");

parent is

    public function __construct($message = "", $code = 0, Throwable $previous = null) { }

so adding a default is closer to the parent

Comments

https://lab.civicrm.org/dev/core/issues/592

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I'm going to merge this as it seems to be the more correct solution

[bjendres]

I'm going to merge this as it seems to be the more correct solution

@seamuslee001: I agree, and definitely more robust.

But shouldn't the default value be undefined, following this or this logic? @eileenmcnaughton?

[eileenmcnaughton]

Hmm maybe -I looked at the parent's default which was 0

[bjendres]

That also makes sense. Let's leave it as it is for now :)

[eileenmcnaughton]

@systopia - I'm glad you came around to the less-effort option :-)