[REF] Minor Test clean up #13269
Merged
[REF] Minor Test clean up #13269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got separated out over a few recent commits (the first one seems to have somewhat accidentally included the trait & then some others added using it. Am just pushing in this tidy up
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
acltesttrait
branch
from
2c9572a
to
8cd1c98
Compare
eileenmcnaughton
force-pushed
the
acltesttrait
branch
from
8cd1c98
to
2ed07c2
Compare
mattwire
reviewed
Dec 13, 2018
| * @param $where | ||
| */ | ||
| public function aclWhereOnlySecond($type, &$tables, &$whereTables, &$contactID, &$where) { | ||
| $where = " contact_a.id > 1"; |
There was a problem hiding this comment.
@eileenmcnaughton Is this function unused? As I can't see a replacement in the trait?
mattwire
reviewed
Dec 13, 2018
| * @param $where | ||
| */ | ||
| public function aclWhereOnlyOne($type, &$tables, &$whereTables, &$contactID, &$where) { | ||
| $where = " contact_a.id = " . $this->allowedContactId; |
There was a problem hiding this comment.
@eileenmcnaughton Is this function unused? As I can't see a replacement in the trait?
|
@eileenmcnaughton So tests are passing. Assuming you meant to remove two unused functions aclWhereOnlyOne and aclWhereOnlySecond this is ok to merge - please confirm that's correct first? |
|
@mattwire yes, they are in the trait & the tests would have failed if there was a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor cleanup within the test classes
Before
Less clean
After
More clean
Technical Details
Uses a trait for permissions functions, some comments cleanup, one unused function removed
Comments
Have at it jenkins - oh when you are ready of course