[REF] Export add test for phone details, fix phone_type_id #13275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
export_more_im
branch
from
d6d225e
to
001a515
Compare
|
Tested a contact export and confirm that the exports are identical. Tests are passing. Ok to merge. |
|
Merging as per Matt's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up fix on exporting phone type
Before
No test, test fails when added
After
Test, test passes
Technical Details
@mattwire cleaning up branches locally I found this test & that it failed. I removed some stuff to get it working - I'm pretty sure Jenkins will fail if those lines are still needed
Comments