Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default of TRUE for is_active on PaymentProcessor.create api. #13291

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Changes metadata on PaymentProcessor api such that is_active is true by default

Before

If PaymentProcessor.create is called with neither id or is_active passed in is_active is set to NULL

After

If PaymentProcessor.create is called with neither id or is_active passed in is_active is set to TRUE

Technical Details

This is consistent with UFGroup, CustomGroup, ComtributionPage etc

Comments

@civibot
Copy link

civibot bot commented Dec 16, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

@eileenmcnaughton test fail looks related

This is consistent with UFGroup, CustomGroup, ComtributionPage etc
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw colemanw merged commit 1a47d07 into civicrm:master Dec 21, 2018
@colemanw colemanw deleted the process_default_active branch December 21, 2018 15:58
@colemanw
Copy link
Member

Merging as tests pass and this corrects an inconsistency in a backward-compat way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants