Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Minimum Required PHP to be 5.6 #13309

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

seamuslee001
Copy link
Contributor

Overview

This bumps the minimum required PHP version to be 5.6 as per https://civicrm.org/blog/eileen/end-of-life-plans-for-5x-php-versions-planning-for-70-eol

Before

Previously minimum php version was 5.5

After

Minimum php version is 5.6

ping @totten @eileenmcnaughton

@civibot
Copy link

civibot bot commented Dec 18, 2018

(Standard links)

@civibot civibot bot added the 5.9 label Dec 18, 2018
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 we should do this for sure. I think we should possibly also increase the const MIN_RECOMMENDED_PHP_VER = '7.0'; variable - since this is the last month of php support for it

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton are we prepared to recommend anything higher than 7.1 at this stage?

@eileenmcnaughton
Copy link
Contributor

And in fact const RECOMMENDED_PHP_VER = '7.1'; - we should be recommending php 7.2 now IMHO

@eileenmcnaughton
Copy link
Contributor

ah snap - YES I think so - there is the smtp password version but I think we just live with the advice that people re-save their passwords when updating to php 7.2

@seamuslee001
Copy link
Contributor Author

done that now @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor

OK - looks good to me!

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 this is the wrong branch I just realised - 5.9 will be the last php 5.5 supporting version

@seamuslee001 seamuslee001 changed the base branch from 5.9 to master December 18, 2018 07:14
@civibot civibot bot added master and removed 5.9 labels Dec 18, 2018
@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton switched to master

@seamuslee001
Copy link
Contributor Author

Merging as per tag

@seamuslee001 seamuslee001 merged commit aa4eead into civicrm:master Dec 18, 2018
@seamuslee001 seamuslee001 deleted the min_php_version_bump branch December 18, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants