Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the Contribution Detail Report link the Amount field to the contribution #13316

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

alifrumin
Copy link
Contributor

@alifrumin alifrumin commented Dec 18, 2018

Overview

In CiviCRM 4.7.29 (not sure when this broke), the "Amount" column in the Contribution Detail Report was linked to the Contribution record, however it is not in CiviCRM 5.8. The code comments also suggest that the "Amount" column should be linked to the Contribution Record. I believe this is a regression.

This change makes it so that the Amount field is once again linked to the Contribution record

Before

In the Contribution Detail Report the Amount column is not linked to the Contribution

See the plain text amounts in the screenshot below:
amount

After

In the Contribution Detail Report the Amount column is linked to the Contribution

See the screenshot below:

after

@civibot
Copy link

civibot bot commented Dec 18, 2018

(Standard links)

@civibot civibot bot added the master label Dec 18, 2018
@alifrumin alifrumin changed the title WIP Link the Amount field to the contribution in the Contribution Detail Report Link the Amount field to the contribution in the Contribution Detail Report Dec 19, 2018
@alifrumin alifrumin changed the title Link the Amount field to the contribution in the Contribution Detail Report On the Contribution Detail Report link the Amount field to the contribution Dec 20, 2018
@jitendrapurohit
Copy link
Contributor

seems to be related to this commit where civicrm_contribution_total_amount was replaced to civicrm_contribution_total_amount_sum.

I've now tested this PR and can confirm that it fixes the issue mentioned in the description.

@seamuslee001
Copy link
Contributor

Given Jitendra's review and the tests have passed this looks good to me looks like an issue from one of your fixes @eileenmcnaughton

@seamuslee001 seamuslee001 merged commit f83b29c into civicrm:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants