Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

campaign cleanup for sybunt report and show disabled campaigns as well #13321

Merged
merged 1 commit into from
Dec 20, 2018
Merged

campaign cleanup for sybunt report and show disabled campaigns as well #13321

merged 1 commit into from
Dec 20, 2018
+2 −22

Conversation

yashodha
Copy link
Contributor

Overview

Centralize and cleanup code for campaigns in reports and show disabled campaigns as well

Before

sybunt_before

After

sybunt_after

Comments

Inactive campaigns can be seen in report filter and results as well.

@civibot
Copy link

civibot bot commented Dec 19, 2018

(Standard links)

@civibot civibot bot added the master label Dec 19, 2018
@yashodha
Copy link
Contributor Author

test this please

@yashodha
Copy link
Contributor Author

@eileenmcnaughton @seamuslee001
clean up changes for report

@eileenmcnaughton
Copy link
Contributor

Looks good to me

@eileenmcnaughton eileenmcnaughton merged commit 4a95afb into civicrm:master Dec 20, 2018
@yashodha
Copy link
Contributor Author

@eileenmcnaughton thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashodha @eileenmcnaughton