add suport for order by clause for campaign and clean up

[yashodha]

Overview

Centralize and cleanup code for campaigns in reports and show disabled campaigns as well
Handled order by clause for campaigns

Before

After

Comments

Inactive campaigns can be seen in report filter and results as well.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass - Tested the report still works as expected
  • (r-doc) Pass
  • (r-run) Pass - Tested the report still works as expected
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Unkown at this stage

[seamuslee001]

Adding merge on pass

[seamuslee001]

Merging as per my review and tag