Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/mail#35 Ensure that Public View link is visible in Scheduled and … #13354

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

seamuslee001
Copy link
Contributor

…Sent Screens

Overview

The code in the Action Links for Mailing Scheduled and Sent and Draft and Unscheduled mailings suggests that a public view link should be there if the mailing is public but it currently doesn't show

Before

No public view link

After

Public View link shows

ping @mattwire @yashodha @monishdeb @eileenmcnaughton

@civibot
Copy link

civibot bot commented Dec 26, 2018

(Standard links)

@civibot civibot bot added the master label Dec 26, 2018
@sunilpawar
Copy link
Contributor

@seamuslee001
I have Tested functionality with your patch.
Public View link was missing even mailing visiblity is 'Public Pages'. After patch link is available.

@seamuslee001
Copy link
Contributor Author

ping @yashodha @monishdeb @eileenmcnaughton are one of you able to merge based on Sunil's review?

@yashodha
Copy link
Contributor

merging this.

@yashodha yashodha merged commit 29e86a0 into civicrm:master Dec 27, 2018
@seamuslee001
Copy link
Contributor Author

thanks @yashodha

@seamuslee001 seamuslee001 deleted the lab_core_35 branch December 27, 2018 08:58
@eileenmcnaughton
Copy link
Contributor

Thanks @yashodha - looks like a good change @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants