(dev/core#491) campaign cleanup for 'pledged but not paid' report and… #13358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… show disabled campaigns as well
|
(Standard links)
|
|
test this please |
CRM/Report/Form/Pledge/Pbnp.php
Outdated
| @@ -49,12 +49,6 @@ public function __construct() { | |||
|
|
|||
| // Check if CiviCampaign is a) enabled and b) has active campaigns | |||
| $config = CRM_Core_Config::singleton(); | |||
There was a problem hiding this comment.
@yashodha L50 and L51 can probably be deleted too i think and maybe L52 as well
|
Tested the report it works as expected and outputs correct information. Just a minor cleanup apart from that this is good to be merged |
|
@seamuslee001 thanks for catching that! done with the changes. |
|
Tested the report and it works fine merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… show disabled campaigns as well.
Overview
Centralize and cleanup code for campaigns in reports and show disabled campaigns as well
Before
After
Comments
Inactive campaigns can be seen in report filter and results as well.