dev/core#680 make receive_date required on backoffice contribution form

[eileenmcnaughton]

Overview

Make receive_date required on backoffice contribution form.

This doesn't appear to be a recent regression but it is commonly understood that this is a required field and unsetting it causes invalid contributions. I put it against the rc because it seems both trivial and clear cut

Before

After

Technical Details

Comments

Discussion on https://lab.civicrm.org/dev/core/issues/680#note_13205

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

Agree with this patch. Remaining would be to indicate 'recieve_date' as required field in schema. But after discussing with @eileenmcnaughton, I agree that we can push that change in master as it involves schema and upgrade change.

Change is safe and doesn't cause any unintended side-effect

[monishdeb]

Test failure is unrelated. Merging now