Add deprecation warnings around code that seems ripe for removal #13789
Conversation
|
(Standard links)
|
| @@ -102,6 +102,9 @@ public static function preProcessCommon(&$form) { | |||
| $form->_contactTypes = array(); | |||
|
|
|||
| $useTable = (CRM_Utils_System::getClassName($form->controller->getStateMachine()) == 'CRM_Export_StateMachine_Standalone'); | |||
| if ($useTable) { | |||
There was a problem hiding this comment.
The real pain point here is the extra code that exists to support this
|
It's used in the civicase extension, although I'm not clear how you actually get to it via UI. |
|
@demeritcowboy maybe that's a reason to merge it! There is a lot of code that supports class that has tech debt & is untested when it changes so if we add the deprecations it will either let us know if it's being used or we can remove over time @colemanw it seems you actually added this - if you look at CRM_Contact_Form_Task:: preProcessCommon it's full of stuff that makes that complicated just to support something that that is not in core & is perhaps not accessible from CiviCase anymore |
|
Yes that was mine, see #11254. It's pretty recent work and is used in the new CiviCase extension. I agree that it could use unit tests but it's not deprecated. |
|
@colemanw does it allow us to bypass security - I see it supports exporting random entities? From my POV the $useTable stuff in core is a problem IMHO - it's shitty handling in that core for stuff that isn't in core |
|
It uses the api to check permissions: https://github.com/civicrm/civicrm-core/blob/master/CRM/Export/Controller/Standalone.php#L48-L48 |
Overview
Add deprecation warnings to code that seems obsolete
Before
Code not marked as obsolete
After
Code marked
Technical Details
This just seems dead...
Comments