(dev/core#1044) Extension/MIME-type matching should be case insensitive #14554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- For CIVI-SA-2019-15, the delivery of file attachments was tightened to ensure that the file-extension and mime-type were in agreement. However, the check yields a false-negative in the common case where the filename has been capitalized. It should treat `foo.jpg`, `foo.JPG`, and `FOO.JPG` as equally valid. Before ------ * When viewing a contact profile image ending with `.JPG`, there is an error message, `Supplied mime-type does not match file extension`. After ----- * When viewing a contact profile image ending with `.JPG`, the image is delivered. Comments -------- See also: * https://civicrm.org/advisory/civi-sa-2019-15-xss-via-forged-mime-type * https://lab.civicrm.org/dev/core/issues/1044
|
(Standard links)
|
|
this is one of a small handful we should put in 5.14.1 release - I haven't totally formed a list yet |
totten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For CIVI-SA-2019-15, the delivery of file attachments was tightened to ensure that the file-extension and mime-type were in agreement. However, the check yields a false-negative in the common case where the filename has been capitalized. It should treat
foo.jpg,foo.JPG, andFOO.JPGas equally valid.This is a backport of #14544.
Before
.JPG, there is an errormessage,
Supplied mime-type does not match file extension.After
.JPG, the image isdelivered.
Comments
See also: