dev/core#1233 Fix deleting of campaigns and saving of custom data for campaign and … #15233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…also ensure that goal_general is not html encoded as it is a wysiwyg field
|
(Standard links)
|
seamuslee001
changed the title
|
I've |
|
MOP based on @totten's testing |
| @@ -55,7 +55,6 @@ public function testSubmit($thousandSeparator) { | |||
| 'custom' => [], | |||
| 'campaign_type_id' => 1, | |||
| ], $form); | |||
| var_dump($form); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…also ensure that goal_general is not html encoded as it is a wysiwyg field
Overview
This fixes the delete action and also fixes saving custom fields for campaign and also ensures that the goal details are not inappropriately html encoded
Before
Cannot delete a campaign with popups turned off and goal details are html encoded
After
Can delete campaign when popups are turned off and goal details properly stored in the database
ping @eileenmcnaughton @totten