dev/core#1602 Fix join date filtering in search builder by standardis…

[seamuslee001]

…ing date field handling in Membership Query BAO

Overview

This is my alternate to #16573 and aims to do more of a standardised fix without generating deprecated notices

Before

Join date field wouldn't filter correctly within Search builder

After

Correct filter is applied when searching via Search builder using the Join date field

ping @eileenmcnaughton @lcdservices

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[lcdservices]

@seamuslee001 I ran through a test and this is working as expected.

[eileenmcnaughton]

good to merge on test pass then

[eileenmcnaughton]

@seamuslee001 do you want to put up a 5.22 pr now - still trying to attract @totten's attention to a drop but this can go in I think

[seamuslee001]

test fail unrelated