(dev/core#1846) Container, ClassLoader Caches - Separate caches by ve…

[seamuslee001]

…rsion number

Before

If you load a new version of the CiviCRM codebase, then a freshness check
should cause the container cache to reset automatically (based on the fact
that various files have new timestamps).

However, it's possible that some kind of bug or omission prevents this from working.
Many developers won't notice such a bug because they're obsessive-compulsive
about clearing caches anyway.

After

If you load a new version of the CiviCRM codebase, then it should use a new
container cache - regardless of how well the freshness check works.

5.28 port of #17740

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Note that the original description in #17740 discussed CachedCiviContainer.XXX.php. We noticed this patch was missing from 5.28 when discussing an error report (from @adixon) about class-loading (ie CachedExtLoader.XXX.php). The classloader problem worked like:

1. Install Civi 5.24 and FlexMailer 1.1.1
2. Upgrade to Civi 5.28 and Flexmailer (bundled)
3. Observe an error: Error: Class 'Civi\FlexMailer\Services' not found in flexmailer_civicrm_container() (line 147 of /var/www/html/sites/all/modules/civicrm/ext/flexmailer/flexmailer.php).
4. This happens because CachedExtLoader.XXX.php is stale.

The mechanics of CachedCiviContainer.XXX.php and CachedExtLoader.XXX.php are extremely similar - even using the same XXX. Consequently, this patch addresses use-cases for both files.

[seamuslee001]

Test Fail unrelated