dev/core#2752 Allow financial_trxns to be viewed #21178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
perm
branch
from
2a13a79
to
6736e61
Compare
eileenmcnaughton
force-pushed
the
perm
branch
from
6736e61
to
daf1111
Compare
eileenmcnaughton
force-pushed
the
perm
branch
2 times, most recently
from
5d0b55b
to
4bc1c5e
Compare
Per https://lab.civicrm.org/dev/core/-/issues/2752 this allows non admins to see payment details in search for contributions they can see. I only added for 'get' because I didn't want to loosen 'delete' (in particular) and this was the minimum extra to achieve search access
|
This seems fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per https://lab.civicrm.org/dev/core/-/issues/2752 this allows non admins to
see payment details in search for contributions they can see.
I only added for 'get' because I didn't want to loosen 'delete'
(in particular) and this was the minimum extra to achieve
search access
Before
User with 'access civicontribute' can see payment details in core screens but not search kit
After
Search details show in search kit
Technical Details
The behaviour has changed a bit over recent releases - on earlier code you get errors rather than missing fields. Missing fields is nicer :-)
Comments