Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum upgradable version to 4.5.9 #21408

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 8, 2021

Overview

Another year, another long-overdue bump to our minimum upgradable version.
4.4 was released back in 2013, so I think it's time to finally say goodbye.

Before

Minimum upgradable version 4.4.7

After

Minimum upgradable version 4.5.9

Comments

People using older versions can still upgrade, but they will have to do it in steps, using an intermediate version like 4.7 before upgrading to the latest.

@civibot
Copy link

civibot bot commented Sep 8, 2021

(Standard links)

@civibot civibot bot added the master label Sep 8, 2021
@eileenmcnaughton
Copy link
Contributor

@colemanw this seems fine to me - I'm just wondering about docs updates

@colemanw
Copy link
Member Author

colemanw commented Sep 8, 2021

@colemanw
Copy link
Member Author

colemanw commented Sep 8, 2021

Not surprisingly, test failures indicate that you are no longer able to upgrade from version 4.5.0!
@seamuslee001 I can't remember what you did to fix that last year for #17750 but we need to do it again to bump up the starting version in the upgrade tests.

colemanw added a commit to civicrm/civicrm-buildkit that referenced this pull request Sep 9, 2021
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

re coleman's question the answer is here civicrm/civicrm-buildkit#648

@demeritcowboy
Copy link
Contributor

Not a blocker but there's a couple spots like this in SEPA Direct Debit: https://github.com/Project60/org.project60.sepa/blob/0e787cca54a0a471d4653206cc45e2bb034a26a0/CRM/Sepa/DAO/SEPAMandate.php#L186

Maybe that needs its DAO's regenerated?

@colemanw
Copy link
Member Author

colemanw commented Sep 9, 2021

Yes it definitely does! Blame says it was last regenerated 8 years ago.
https://github.com/Project60/org.project60.sepa/blame/0e787cca54a0a471d4653206cc45e2bb034a26a0/CRM/Sepa/DAO/SEPAMandate.php#L186

@eileenmcnaughton eileenmcnaughton merged commit ea7a058 into civicrm:master Sep 10, 2021
@eileenmcnaughton eileenmcnaughton deleted the bumpMinUpgradeVer branch September 10, 2021 00:30
seamuslee001 pushed a commit to seamuslee001/civicrm-sysadmin-guide that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants