Move two more functions to financialProcessor #21927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
trxn
branch
2 times, most recently
from
240849f
to
b3a1c34
Compare
|
No shortage of test cover then :-) I just moved 1 more function over given the test results indicated that I'd just moved the only place that called it |
eileenmcnaughton
force-pushed
the
trxn
branch
from
b3a1c34
to
213cfa8
Compare
|
test fails don't make sense. |
|
@demeritcowboy the test fails seem to affect all PRs now |
|
See #22269 |
|
test this please |
|
thanks @demeritcowboy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move two more functions to financialProcessor
Before
Functions are part of the borg
After
Moved to the class they interact with
Technical Details
Part of preparing for some bug fixes
Comments