[WIP] dev/core#2927 - tests for is_dir replacement #22004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
demeritcowboy
force-pushed
the
test-isdir
branch
from
f690334
to
a1a802a
Compare
|
@demeritcowboy is there anything that is preventing us from merging this, this seems pretty good to me |
|
It doesn't test the proposed new function yet, it's just testing php's own is_dir. It needs to be combined with the other PR and then part of it adjusted because the point of that other PR is to silence some of the errors. |
|
Closing for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See #21923
https://lab.civicrm.org/dev/core/-/issues/2927
Tests based on php's own tests for is_dir.
@herbdool This is where I'm going but first checking if this runs at all in the test env here. Then would switch it over to call the new function instead of is_dir and adjust the expected output for the basedir ones.
Before
What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note