Smarty variables] Remove isset from batch form #22187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Stacktrace /home/jenkins/bknix-dfl/build/core-22187-36q9f/web/sites/all/modules/civicrm/tests/phpunit/api/v4/Action/DateTest.php:96 |
|
test this please |
eileenmcnaughton
changed the title
|
test this please |
eileenmcnaughton
force-pushed
the
smarty13
branch
from
5198142
to
d98d889
Compare
|
@colemanw this is failing only on a known test fail - should be an easy one |
|
jenkins retest this please |
| @@ -9,7 +9,7 @@ | |||
| *} | |||
|
|
|||
| {* Financial search component. *} | |||
| {if !isset($batchStatus)} | |||
| {if $batchStatus} | |||
There was a problem hiding this comment.
Should be !$batchStatus
eileenmcnaughton
force-pushed
the
smarty13
branch
from
d98d889
to
e8994a1
Compare
Affects url civicrm/financial/financialbatches?reset=1&batchStatus=1
eileenmcnaughton
force-pushed
the
smarty13
branch
from
e8994a1
to
5218709
Compare
|
@demeritcowboy I've updated this - on review I've changed the approach slightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Affects url civicrm/financial/financialbatches?reset=1&batchStatus=1
Before
fatal with hardened smarty
After
ok
Technical Details
Comments