(REF) CRM/Upgrade - Remove unused entrypoint verifyPreDBstate()
#22237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- In olden times, upgraders sometimes implemented the method `verifyPreDBstate()`. However, this appears to be unused. Additionally, it's not clear (from the documentation) how you would use it (if you wanted to). So... simplify the code.... Before ------ Function exists. But it does nothing. Because no subclasses implement it. After ----- Function does not exist. It still does nothing.
|
(Standard links)
|
|
I saw nothing. |
|
Added docs update: https://lab.civicrm.org/documentation/docs/dev/-/merge_requests/979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In olden times, upgraders sometimes implemented the method
verifyPreDBstate(). However, this appears to be unused.Additionally, it's not clear (from the documentation) how you would use it (if you wanted to).
So... simplify the code....
Before
Function exists. But it does nothing. Because no subclasses implement it.
After
Function does not exist. It still does nothing.