dev/core#2825 - Make source contact required for activities on the form

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2825

Before

It's possible to edit a case activity and remove the source contact. You don't notice it on the regular activity form because postprocess will fill in the current user, but on a case activity it stays blank and then causes problems later such as disappearing from manage case and crashing the Print Report.

After

Both types of activities have it required.

Technical Details

It's a quickfix because you'll still have case problems if you permanently delete a contact (https://lab.civicrm.org/dev/core/-/issues/1251). That could be considered a bigger issue though because you've lost important data if you do that.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Makes sense... except that if postprocess fills it with current user then is it a normal workflow to leave it blank?

[demeritcowboy]

The default is always the logged in user, so it's never blank to start.

[demeritcowboy]

The other functions call parent::XX so share with the regular activity. The case activity doesn't call parent for post process. So a different quickfix would be to copy the code from postprocess that fills in the current user if blank.

[colemanw]

In that case I think this fix is fine.

[seamuslee001]

Jenkins re test this please

[demeritcowboy]

Hmm, any updates made to jenkins itself? This seems to happen after all the tests have run:

ERROR: Step ‘Publish xUnit test result report’ failed: The result file '/home/jenkins/workspace/CiviCRM-Core-PR/junit/CRM_AllTests.xml' for the metric 'JUnit' is not valid. The result file has been skipped.

[seamuslee001]

yeh I upgraded the xunit plugin and its doing interesting things

[seamuslee001]

Jenkins re test this please

[kainuk]

I just checked it on the generated test. It works fine.

[demeritcowboy]

Thanks!