Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Duplicate function to allow us to work it out of the code #22254

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 15, 2021

Overview

[REF] Duplicate function to allow us to work it out of the code

Before

The dedupe code does a LOT of work to prepare for this function to do a LOT of work - most of it could go but because the function is toxic AND shared with other bits of code it is hard to unravel

After

Function is duplicated - allowing cleanup to happen without breaking other code

Technical Details

Comments

@civibot
Copy link

civibot bot commented Dec 15, 2021

(Standard links)

@civibot civibot bot added the master label Dec 15, 2021
@colemanw
Copy link
Member

Oof, what a nasty function. At least now there's two of them 🤣

@colemanw colemanw merged commit 5433c81 into civicrm:master Dec 15, 2021
@colemanw colemanw deleted the prof branch December 15, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants