Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#567 Add test shell #22275

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This adds the test shell for https://lab.civicrm.org/dev/core/-/issues/567 which has previously been blocked on needing a test.

I looked at #22100 and thought to direct to where the test would go & then realised the test would be easy to write. However, I've left is as not actually testing - just providing clues. When I dug into the code that would need changing I realised I wasn't comfortable making the proposed change without some cleanup prior to making the change. I will separately put up a PR to un-share the processFormContribution function as the shared nature of that function is a major contributor to the problems with it.

Before

Hard for people to know where to add tests

After

Shell test exists - will add to the issue

Technical Details

Comments

@civibot
Copy link

civibot bot commented Dec 19, 2021

(Standard links)

@civibot civibot bot added the master label Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants