dev/core#2927 - Avoid flooding logs with open_basedir in effect #22277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
demeritcowboy
force-pushed
the
isdir2
branch
from
8c45c23
to
5ecffeb
Compare
|
@agileware-justin Do you have time to test this PR on the site(s) where you had the problem? |
|
Thanks @demeritcowboy Sorry, I didn't see this PR. We have these PRs in our build and that's been deployed. Possibly, looks like we need to include getEntityNames and loadEntity in this PR. I'll review this one too. |
|
Yep those 2 funcs are in this PR. |
|
Testing looks good so far @demeritcowboy - no more spam. |
|
Have not seen any changes to the amount of log spamming after removing #21591 and adding this PR. So things are still relatively quiet in the web server log, which is good. And I'm not seeing any new errors in CiviCRM. Just all the old ones. So that's good too. Tentative thumbs up. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/2927
Followup to #22107 and its inspirations
Before
Lots of log entries about open_basedir when e.g. visiting api explorer
After
Less
Technical Details
Comments
@agileware-justin @herbdool These are the only ones that seem to try to access directories that would be outside the civi tree or extension folders or places where files are kept. Such places would need to be inside open_basedir for civi to function in the first place, so leaving them at is_dir seems better.