Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply default escaping to multiselects on currency form #22294

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 22, 2021

Overview

Do not apply default escaping to multiselects on currency form

Before

Multi selects don't render with escape by defautl on localisation form

image

After

Tada

image

Technical Details

This is probably an html pattern we have missed in our early returns but
explictly marking the fields not to be escaped is probably better now the bulk is weeded out

Comments

This is probably an html pattern we have missed in our early returns but
explictly marking the fields not to be escaped is probably better now the bulk is weeded out
@civibot
Copy link

civibot bot commented Dec 22, 2021

(Standard links)

@civibot civibot bot added the master label Dec 22, 2021
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 can I get a merge on this?

@seamuslee001 seamuslee001 merged commit 163396f into civicrm:master Dec 22, 2021
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants