Demo sample data - Add in some mixed currency contributions #22307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
mixed_currency
branch
5 times, most recently
from
6b2b385
to
04c18f9
Compare
This fixes some of the contributions & recurring contributions to be in currencies other than USD. I also found that a lot of the contributions being created are either in 2010 or on the generation date so I spread the dates out a bit - although that meant making it a bit easier to keep the activities in sync. It turns out the API does work in this context - and that would create the activities more faithfully - but the issues around the processor being created by a different process are a bit challenging
eileenmcnaughton
force-pushed
the
mixed_currency
branch
from
04c18f9
to
be94691
Compare
eileenmcnaughton
changed the title
|
Tested clean and sample data install. Looks good. Contributions 2 and 5 are the same except for transaction id, but that's maybe not a bad thing since real data can be like that. And it's pre-existing that all the dates are "today" for the other contributions that get generated. Comments in #22305 support the idea of adding the currencies to a clean install. |
|
thanks @demeritcowboy - I think the other contributions are memberships & yeah they are a bit samey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add in some mixed currency contributions
Before
All contributions and the (newly added) recurring contributions are in USD
After
A smattering of other currencies
Technical Details
This includes the 'all new installs' approach to having more currencies than just USD
#22305
Comments
Putting the definition in an array rather than raw sql will be more useful in next rounds on this code