SqlParallel - Enable more tests. Fix compatiblity with release_time
#22326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The unit-test
CRM_Queue_QueueTest
provides some generic test-coverage for a couple different backends (Sql
,Memory
). This expands it to also testSqlParallel
.One test case,
testTimeoutRelease()
, was failing when run withSqlParallel
. The PR updates it to pass.@artfulrobot I can't recall if there is a reason why
SqlParallel
changed therelease_time
filter?Before
Sql
andMemory
-backed queues, theclaimItem()
logic will select items with any of these three dispositions:release_time=null
)release_time=NNN
)release_time=NNN
).SqlParallel
,claimItem()
will only select items in this case:release_time=null
)After
Sql
,Memory
, andSqlParallel
, therelease_time
works the same way. It should support all 3 scenarios.release_time=null
)release_time=NNN
)