Remove unused method getGrantStatusOptGroup #22332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unused method getGrantStatusOptGroup.
Technical Details
I spotted this method was unused as a result of my IDE warning me that
CRM_Grant_BAO_Grant::$statusGroupName
was unset. Therefore even if this method was in use, I do not belive it would work correctly.Checking with
git log -S getGrantStatusOptGroup
andgit log -S statusGroupName
it appears this method was not in use when the migration from SVN took place, and the method has not been referenced since.Based on these factors it seems sensible to remove the method.